add correlation coefficient colormaps #24
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks @wx4stg again for the PR! Tomorrow I will submit some minor PEP8 and unit test changes, then this should be good to go. |
mgrover1
approved these changes
Nov 6, 2023
|
Nice work @wx4stg, let's merge then. |
|
Merging! |
|
|
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds colormaps designed for correlation coefficient radar products:
NWS_CCwhich I reverse-engineered from AWIPS CAVE. Recommend vmin=0, vmax=1.05plasmidis, combination of matplotlib viridis and plasma_r that diverges and lightness at 0.95 if vmin=0 and vmax=1The motivation behind plasmidis is an attempt to be more CVD-friendly than NWS_CC by making the lightness reversal matter (0.95 is subjectively what I look for mixed ice and liquid targets, anything less probably suggests hail and much less suggests non-meteorological targets).
NWS_CC is provided for backwards compatibility/legacy/familiarity/etc.
Test data used: https://noaa-nexrad-level2.s3.amazonaws.com/2021/04/09/KGRK/KGRK20210409_015238_V06
As proven by our fun last year in ARM-DOE/pyart#1325 , y'all have much better cvd/colormap test suites than I, so let me know If I was successful or what can be improved :) The ulterior motivation behind this PR is that I'm doing research involving polarimetric products, and I didn't want to use the RefDiff cmap for ZDR and CC. This is just my first swing at it, improvements/suggestions welcomed and encouraged.