Don't error out on description when tproc=False #307
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jcpunk
force-pushed
the
tproc-info-optional
branch
4 times, most recently
from
a9511b0 to
7b054ee
Compare
jcpunk
force-pushed
the
tproc-info-optional
branch
from
37af01a to
25545f5
Compare
|
Thanks, this makes sense - let me know when it's ready to merge. |
|
I believe it is ready whenever you'd like to merge it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As I'm playing with the test code, I noticed the description function doesn't behave if there are no
tprocs(soc = RFQickSoc216V1('./test_rf216_v2p2_kt.bit', clk_output=None, no_tproc=True)).This adds guards for the obvious cases and should result in the
tproccalls behaving and reporting no results.