Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct encoding of quote and add a unit test #472

Merged
merged 1 commit into from
Oct 18, 2019

Conversation

tledoux
Copy link
Contributor

@tledoux tledoux commented Sep 3, 2019

Fixes #471

@codecov
Copy link

codecov bot commented Sep 3, 2019

Codecov Report

Merging #472 into integration will increase coverage by 0.18%.
The diff coverage is 100%.

Impacted file tree graph

@@                Coverage Diff                @@
##             integration     #472      +/-   ##
=================================================
+ Coverage          49.36%   49.54%   +0.18%     
- Complexity           969      974       +5     
=================================================
  Files                 55       55              
  Lines               7666     7666              
  Branches            1392     1392              
=================================================
+ Hits                3784     3798      +14     
+ Misses              3422     3412      -10     
+ Partials             460      456       -4
Impacted Files Coverage Δ Complexity Δ
...in/java/edu/harvard/hul/ois/jhove/HandlerBase.java 74.61% <100%> (+7.25%) 51 <0> (+5) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dd25d0f...b330f21. Read the comment docs.

@tledoux tledoux requested a review from carlwilson September 3, 2019 16:17
@tledoux
Copy link
Contributor Author

tledoux commented Sep 9, 2019

@carlwilson : Hi, just a little squash to make the merge easier.

This correct a long standing bug that has been revealed by the new error messages...

@tledoux tledoux added the bug A product defect that needs fixing label Sep 9, 2019
@carlwilson carlwilson added the P2 Medium priority issues to be scheduled in a future release label Oct 18, 2019
@carlwilson carlwilson added this to the v1.24-m4 Release milestone Oct 18, 2019
@carlwilson carlwilson merged commit 0ec3d4f into openpreserve:integration Oct 18, 2019
@tledoux tledoux deleted the issue471 branch October 19, 2019 10:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug A product defect that needs fixing P2 Medium priority issues to be scheduled in a future release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Submessage encoding in xml result
2 participants