Improve form module reactivity #168
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…les not dependent on `r` anymore
…original data is missing, and there is an explanation for missingness. Note: only implemented for continuous data now!
…ounce() in mod_studsy_forms for the fig_data() )
Split review data
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed, this PR will move all the logic for creating a (review) table from
mod_common_formsandmod_study_formsto the already existingmod_review_forms_tblmodule. In addition, only data from one form will be passed to the the modules.This removes code duplication in the modules, it reduces reactivity (e.g. it will not reload all the table/figure data of form B when a review in form A is saved).
In addition, I refactored some code in
mod_review_forms_tbl, and fixed some smaller bugs in thecreate_tablefunctions, such as data showing up asNAin the tables when data is new (because html bold tags are added in the app):but showing as intended when data is reviewed:
Multiple tests are added to test the business logic for merging a table created with
create_table.Furthermore, a start was made to create a module test for the
mod_review_form_tblmodule.