Further improvement of Performance #1544
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vvmruder
requested review from
peterschaer,
voisardf,
kdeininger,
jwkaltz,
mki-c2c and
michmuel
Codecov Report
@@ Coverage Diff @@
## master #1544 +/- ##
==========================================
+ Coverage 70.78% 70.80% +0.02%
==========================================
Files 121 121
Lines 4970 4988 +18
==========================================
+ Hits 3518 3532 +14
- Misses 1452 1456 +4
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
|
Looks good to me, Thanks. It is certainly better to read those informations only once. Regarding the overall performance see my notes in #1508 |
peterschaer
approved these changes
Apr 13, 2022
|
@voisardf @kdeininger @michmuel I would be happy to see a quick review on that too :) |
michmuel
reviewed
Apr 14, 2022
michmuel
approved these changes
Apr 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@peterschaer
I did a quick profile of the extract generation (based on our small test data set). It reveals several points to poke around. But one easy catch is right in the beginning of the process:
Is related to #1508
As you can see we lose almost 4% of process time between start and ExtractReder.read, I found that we had an old left over in the code. Instead of reading glossaries, disclaimers and municipalities for every extract they are read once on server start now.
Could you please try and tell what you think about this?
To use this patch it should be enough to install it. No config changes needed.