Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: prevent duplication of location header #369

Merged
merged 3 commits into from
Mar 6, 2024
+10 −7
Merged

fix: prevent duplication of location header #369

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e671248
fix: prevent duplication of location header
r34son Feb 26, 2024
f83c883
changeset
conico974 Mar 6, 2024
8817d89
fix linting
conico974 Mar 6, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 2 additions & 7 deletions packages/open-next/src/adapters/routing/middleware.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -123,18 +123,13 @@ export async function handleMiddleware(
// If the middleware returned a Redirect, we set the `Location` header with
// the redirected url and end the response.
if (res.statusCode >= 300 && res.statusCode < 400) {
const location = result.response.headers
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

iirc, we had to handle this case specifically for middleware Redirects. Can you verify that it works with this change?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, i`ve tested it by patching 2.3.6 version. Maybe I need to cover this case by some tests? Do you have any contributing docs?

Copy link
Contributor

@khuezy khuezy Feb 26, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe we have this covered

App: https://github.com/sst/open-next/blob/main/examples/app-router/middleware.ts#L8

.get("location")
?.replace("http://localhost:3000", `https://${req.headers.host}`);
resHeaders.location = resHeaders.location?.replace("http://localhost:3000", `https://${req.headers.host}`);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure this will work on every case, what if you set the uppercase Location headers in the middleware ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

here i mentioned that it doesn't matter uppercase or lowercase, key will be lowercase always
#368 (comment)

// res.setHeader("Location", location);
return {
body: "",
type: internalEvent.type,
statusCode: res.statusCode,
headers: {
...resHeaders,
Location: location ?? "",
},
headers: resHeaders,
isBase64Encoded: false,
};
}
Expand Down