Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(fix) O3-4341: Fix modal close buttons placement in the lab app #114

Merged

Conversation

Muppasanipraneeth
Copy link
Contributor

@Muppasanipraneeth Muppasanipraneeth commented Jan 14, 2025

Requirements

  • This PR has a title that briefly describes the work done including the ticket number. If there is a ticket, make sure your PR title includes a conventional commit label. See existing PR titles for inspiration.
  • My work conforms to the OpenMRS 3.0 Styleguide and design documentation.
  • My work includes tests or is validated by existing tests.

Summary

while clicking the pick lab request in the laboratory app and reject lab request
modal pop for that close icon is not aligned correctly
[close modal css is not aligned correctly ]

Screenshots

Before

Screenshot 2025-01-14 at 8 14 50 AM Screenshot 2025-01-14 at 8 14 38 AM

After

Screenshot 2025-01-14 at 8 35 57 AM Screenshot 2025-01-14 at 8 36 06 AM

Other

x

@Muppasanipraneeth
Copy link
Contributor Author

@denniskigen

Copy link
Member

@denniskigen denniskigen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks, @Muppasanipraneeth!

@denniskigen denniskigen changed the title (fix) O3 4341 : broken modal close buttons (fix) O3 4341: Fix modal close buttons placement in the lab app Jan 14, 2025
@denniskigen denniskigen merged commit e07a752 into openmrs:main Jan 14, 2025
4 checks passed
@denniskigen denniskigen changed the title (fix) O3 4341: Fix modal close buttons placement in the lab app (fix) O3-4341: Fix modal close buttons placement in the lab app Jan 14, 2025
@Muppasanipraneeth
Copy link
Contributor Author

thanks @denniskigen 😊

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants