-
Notifications
You must be signed in to change notification settings - Fork 425
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
AC-839 Updated UI for form list card view #809
Conversation
Codecov Report
@@ Coverage Diff @@
## master #809 +/- ##
==========================================
+ Coverage 13.49% 13.64% +0.15%
==========================================
Files 238 237 -1
Lines 9659 9552 -107
Branches 924 917 -7
==========================================
Hits 1303 1303
+ Misses 8250 8143 -107
Partials 106 106
Continue to review full report at Codecov.
|
@rishabh-997 is displaying DOB necessary?? it dosent look good cant we just remove it all together? |
Do you mean something like this??? Both looks good to me. Thoughts @f4ww4z sir |
yes actually since its quite a low level detail and I think its unnecessary to put up here |
@rishabh-997 I agree with @LuGO0 , remove the DOB. Also decrease the margin between the cards. Can you also post a screenshot for dark mode when it's done? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM @rishabh-997
Description of what I changed
Issue I worked on
JIRA Issue: https://issues.openmrs.org/browse/AC-839
Checklist: I completed these to help reviewers :)
(the number above, next to the 'Commits' tab is 1).
existing code that was well tested you do not have to add tests)