Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AC-839 Updated UI for form list card view #809

Merged
merged 2 commits into from
Aug 28, 2020

Conversation

rishabh-997
Copy link
Collaborator

Description of what I changed

Issue I worked on

JIRA Issue: https://issues.openmrs.org/browse/AC-839

Checklist: I completed these to help reviewers :)

  • My pull request only contains ONE single commit
    (the number above, next to the 'Commits' tab is 1).
  • I have added tests to cover my changes. (If you refactored
    existing code that was well tested you do not have to add tests)
  • All new and existing tests passed.
  • My pull request is based on the latest changes of the master branch.

@rishabh-997
Copy link
Collaborator Author

The date is DOB, not startVisitDate because the activity gets active visits from room, which is null in case there are no active visits. Therefore, in order to maintain uniformity, I am displaying DOB...

WhatsApp Image 2020-08-23 at 2 55 27 AM

@codecov-commenter
Copy link

codecov-commenter commented Aug 22, 2020

Codecov Report

Merging #809 into master will increase coverage by 0.15%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #809      +/-   ##
==========================================
+ Coverage   13.49%   13.64%   +0.15%     
==========================================
  Files         238      237       -1     
  Lines        9659     9552     -107     
  Branches      924      917       -7     
==========================================
  Hits         1303     1303              
+ Misses       8250     8143     -107     
  Partials      106      106              
Impacted Files Coverage Δ
...ormentrypatientlist/FormEntryPatientListAdapter.kt 0.00% <0.00%> (ø)
...es/activevisits/ActiveVisitsRecyclerViewAdapter.kt 0.00% <0.00%> (ø)
...es/patientdashboard/charts/ChartsViewActivity.java 0.00% <0.00%> (ø)
...patientdashboard/charts/PatientChartsFragment.java 0.00% <0.00%> (ø)
...ientdashboard/charts/PatientChartsListAdapter.java
...ies/patientdashboard/charts/VitalsListAdapter.java
...board/charts/PatientChartsRecyclerViewAdapter.java 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ca4ad94...c58be47. Read the comment docs.

@LuGO0
Copy link
Collaborator

LuGO0 commented Aug 23, 2020

@rishabh-997 is displaying DOB necessary?? it dosent look good cant we just remove it all together?

@rishabh-997
Copy link
Collaborator Author

rishabh-997 commented Aug 23, 2020

cant we just remove it all together

Do you mean something like this??? Both looks good to me. Thoughts @f4ww4z sir
Group 63 (2)

@LuGO0
Copy link
Collaborator

LuGO0 commented Aug 24, 2020

cant we just remove it all together

Do you mean something like this??? Both looks good to me. Thoughts @f4ww4z sir
Group 63 (2)

yes actually since its quite a low level detail and I think its unnecessary to put up here

@f4ww4z
Copy link
Collaborator

f4ww4z commented Aug 25, 2020

@rishabh-997 I agree with @LuGO0 , remove the DOB. Also decrease the margin between the cards. Can you also post a screenshot for dark mode when it's done?

@rishabh-997
Copy link
Collaborator Author

Can you also post a screenshot for dark mode when it's done?

WhatsApp Image 2020-08-26 at 12 26 22 AM

Copy link
Collaborator

@f4ww4z f4ww4z left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@f4ww4z f4ww4z merged commit 147dc59 into openmrs:master Aug 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants