Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AC-830 Added repository abstraction for formDisplay package #799

Merged
merged 2 commits into from
Aug 15, 2020

Conversation

LuGO0
Copy link
Collaborator

@LuGO0 LuGO0 commented Aug 11, 2020

Description of what I changed

  1. added a method for accessing the dao in the repository.
  2. added repository to the presenter .

Issue I worked on

JIRA Issue: https://issues.openmrs.org/browse/AC-830

Checklist: I completed these to help reviewers :)

  • My pull request only contains ONE single commit
    (the number above, next to the 'Commits' tab is 1).
  • I have added tests to cover my changes. (If you refactored
    existing code that was well tested you do not have to add tests)
  • All new and existing tests passed.
  • My pull request is based on the latest changes of the master branch.

@LuGO0
Copy link
Collaborator Author

LuGO0 commented Aug 11, 2020

@f4ww4z Its done please review, and I think its quite reasonable to let the services make restAPI calls so they dont need to be linked with the repository??
other than this I think this was the only violation present!!

@codecov-commenter
Copy link

codecov-commenter commented Aug 11, 2020

Codecov Report

Merging #799 into master will increase coverage by 0.00%.
The diff coverage is 66.66%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #799   +/-   ##
=======================================
  Coverage   13.43%   13.43%           
=======================================
  Files         238      238           
  Lines        9698     9697    -1     
  Branches      931      931           
=======================================
  Hits         1303     1303           
+ Misses       8289     8288    -1     
  Partials      106      106           
Impacted Files Coverage Δ
...le/activities/formdisplay/FormDisplayActivity.java 0.00% <ø> (ø)
...tivities/formdisplay/FormDisplayMainPresenter.java 0.00% <0.00%> (ø)
...openmrs/mobile/api/repository/VisitRepository.java 68.36% <76.92%> (-1.43%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 891cc2b...ae9821f. Read the comment docs.

LuGO0 added 2 commits August 13, 2020 02:32
1. added a method for accessing the dao .
2. added repository to the presenter .
@LuGO0 LuGO0 force-pushed the AC-830 branch 2 times, most recently from 8d8401f to ae9821f Compare August 12, 2020 21:03
@f4ww4z f4ww4z changed the title AC-830 removed use of database directly from presenter AC-830 Added repository abstraction for formDisplay package Aug 15, 2020
Copy link
Collaborator

@f4ww4z f4ww4z left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM @LuGO0 ! Service can be linked straight to rest API calls for now.

@f4ww4z f4ww4z merged commit 0f0bb23 into openmrs:master Aug 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants