-
Notifications
You must be signed in to change notification settings - Fork 425
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
AC-809 Create allergy based on server configuration #796
Conversation
I am creating PR to keep a check on Travis errors for each commit. Will finalize this PR by tomorrow morning |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@rishabh-997 To make this feature easier to see, you should modify the floating action button on the bottom right so that when going to the allergy tab it is changed to a +
button for creating a new allergy. See this animation for example.
Codecov Report
@@ Coverage Diff @@
## master #796 +/- ##
==========================================
- Coverage 13.95% 13.52% -0.43%
==========================================
Files 229 238 +9
Lines 9329 9632 +303
Branches 903 924 +21
==========================================
+ Hits 1302 1303 +1
- Misses 7921 8223 +302
Partials 106 106
Continue to review full report at Codecov.
|
a19d068
to
927e31c
Compare
alertDialog = alertDialogBuilder.create(); | ||
alertDialog.show(); | ||
} else { | ||
ToastUtil.notify("Under Progress"); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not added in strings.xml
or ApplicationConstants.kt
since I will remove it in the update-allergy PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM @rishabh-997
I think there has been some error while mierging as lastest commit history shows all 10 commits I made in this PR... @f4ww4z sir |
Description of what I changed
Issue I worked on
JIRA Issue: https://issues.openmrs.org/browse/AC-809
Checklist: I completed these to help reviewers :)
(the number above, next to the 'Commits' tab is 1).
existing code that was well tested you do not have to add tests)