Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AC-794 Notify users when active visits or formlist pages are empty #771

Merged
merged 2 commits into from
Jul 3, 2020

Conversation

rishabh-997
Copy link
Collaborator

Description of what I changed

  1. Added snack bar "Select Form entry from the menu" with the action button to take you there.
  2. Added snack bar "No Forms Found, try restarting the app." when the form list is empty.

Issue I worked on

JIRA Issue: https://issues.openmrs.org/browse/AC-794

Checklist: I completed these to help reviewers :)

  • My pull request only contains ONE single commit
    (the number above, next to the 'Commits' tab is 1).
  • I have added tests to cover my changes. (If you refactored
    existing code that was well tested you do not have to add tests)
  • All new and existing tests passed.
  • My pull request is based on the latest changes of the master branch.

@rishabh-997
Copy link
Collaborator Author

rishabh-997 commented Jun 24, 2020

85574364-53f08080-b654-11ea-8785-286345cfd9a2 (1)

@codecov-commenter
Copy link

codecov-commenter commented Jun 25, 2020

Codecov Report

Merging #771 into master will decrease coverage by 0.03%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #771      +/-   ##
==========================================
- Coverage   11.73%   11.69%   -0.04%     
==========================================
  Files         251      251              
  Lines       10867    10898      +31     
  Branches     1107     1108       +1     
==========================================
  Hits         1275     1275              
- Misses       9493     9524      +31     
  Partials       99       99              
Impacted Files Coverage Δ
...s/mobile/activities/formlist/FormListFragment.java 0.00% <0.00%> (ø)
...rs/mobile/activities/introduction/IntroActivity.kt 0.00% <0.00%> (ø)
...s/mobile/activities/introduction/SplashActivity.kt 0.00% <0.00%> (ø)
...ivities/visitdashboard/VisitDashboardFragment.java 0.00% <0.00%> (ø)
...g/openmrs/mobile/utilities/ApplicationConstants.kt 10.52% <0.00%> (-0.59%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2764f2b...db58c8e. Read the comment docs.

Copy link
Collaborator

@f4ww4z f4ww4z left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rishabh-997 Just a few small changes before we can merge.

Copy link
Collaborator

@f4ww4z f4ww4z left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rishabh-997 Can you fix the merge conflict caused by #767 ? We had to get that PR merged and out of the way first.

@f4ww4z f4ww4z merged commit b5f7980 into openmrs:master Jul 3, 2020
@rishabh-997 rishabh-997 deleted the AC-794 branch July 14, 2020 17:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants