-
Notifications
You must be signed in to change notification settings - Fork 425
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
AC-794 Notify users when active visits or formlist pages are empty #771
Conversation
...lient/src/main/java/org/openmrs/mobile/activities/visitdashboard/VisitDashboardFragment.java
Show resolved
Hide resolved
...lient/src/main/java/org/openmrs/mobile/activities/visitdashboard/VisitDashboardFragment.java
Outdated
Show resolved
Hide resolved
Codecov Report
@@ Coverage Diff @@
## master #771 +/- ##
==========================================
- Coverage 11.73% 11.69% -0.04%
==========================================
Files 251 251
Lines 10867 10898 +31
Branches 1107 1108 +1
==========================================
Hits 1275 1275
- Misses 9493 9524 +31
Partials 99 99
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@rishabh-997 Just a few small changes before we can merge.
openmrs-client/src/main/java/org/openmrs/mobile/activities/formlist/FormListFragment.java
Outdated
Show resolved
Hide resolved
...lient/src/main/java/org/openmrs/mobile/activities/visitdashboard/VisitDashboardFragment.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@rishabh-997 Can you fix the merge conflict caused by #767 ? We had to get that PR merged and out of the way first.
Description of what I changed
Issue I worked on
JIRA Issue: https://issues.openmrs.org/browse/AC-794
Checklist: I completed these to help reviewers :)
(the number above, next to the 'Commits' tab is 1).
existing code that was well tested you do not have to add tests)