-
Notifications
You must be signed in to change notification settings - Fork 232
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Geography-Driven Events #503
Geography-Driven Events #503
Conversation
How do folks feel about trying to get this in for 1.1.0? @quicklywilliam @schnuerle @billdirks |
Feel good about it for 1.1. Milestone marked. |
Probably want to spell out some use cases for Also off the top of my head I'm not coming up with a use case for Policy enforcement where the enter/leave geography events are needed. Do you have some examples of a Policy whose enforcement requires these events once you drop the |
@Karcass these are interesting questions. I'm wondering if there might be a way that we could unify the events, so that there's just a single As for uses cases, one that has came up when we started talking to cities about this was for assessing fees. For example, suppose a city wants to assess a 25 cent fee for trips entering or starting downtown during rush hour. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added some suggestions about not conflating telemetry (movement of vehicle in same state) with events (change of vehicle state).
Also we will need to be super clear on how Geographies are communicated, such that the Providers' notions of currently relevant Geographies is in sync with the regulating Agency. Geographies themselves do not have start-dates or end-dates; applicability is for Policies or Jurisdictions or Metrics to specify. Solving that problem cleanly blocks this proposal IMHO.
We reviewed this PR as part of the second OMF Working Group Steering Committee release Checkpoint. Both WGSCs had some feedback and I'm documenting it here for discussion. Note: we definitely want to flag this as a 'beta' feature in the release, so leaving a reminder here. We were trying to think how geographies can best be aligned to this, how do you know which geography is used for an event? And how can this idea be addressed in the simplest way initially, with minimal changes or dependencies on other things like Jurisdictions. Idea 1) Maybe just use all geographies and return data for all of them by default, then the city can decide which geographies are of value. As part of it being beta, recommend cities talking to providers first to provide a list of geographies it applies to. Idea 2) There could be a new rule type in policy. One that is 'event' and you would define the geography and details there. This may be a bit duplicative, since you would also use that geography in another rule type. Idea 3) Events could be an optional flag in policy that says that this policy needs to be treated as an event. What do you all think of these ideas? I like Idea 3, but I'm not sure it meets all of your use cases @quicklywilliam. |
All set! Have also updated the agenda with details of what needs to be covered. |
From the Working Group call last week, here is a summary of the discussions and action items that should be done in the next week or two to make this release:
|
There's about a week left to get these changes into the PR for this release @quicklywilliam. If you can do that we can save some time on the last WG call Nov 12, though that day is filling up with some other items now like Metrics and k-values, so Nov 5 may be better (though it's of course much sooner!). |
…case where event_geographies is not present.
@schnuerle I'll post an update on this shortly so that we can discuss and resolve most, if not all, of the remaining points. |
…ography event The inclusion of the leave event introduced complexity and ambiguity around which event_geographies should be communicated. For every other event, event_geographies simply consists of every Geography that contains the location of the event. However, for a leave event it is unclear whether event_geographies should contain the geographies the vehicle just left. Removing this event resolves this ambiguity, the list of geographies left can be inferred if neeeded.
We've now resolved the remaining issues discussed at the WG:
|
This change specify that a crossed_geography_boundary event is delivered after the boundary cross has occured – ie the vehicle is now in the new geographies
One thing I want to call attention to is that in resolving the issues above I decided to eliminate the However, I came to a new conclusion in considering how to best clarify the question of which geometries are communicated with these events. The inclusion of the leave event was adding hidden complexity here. For every event type besides leave, the location given is of the vehicle in its new state – not the one it has just transitioned from. However, for a leave event it is unclear – it would seem that event_geographies should contain the geographies the vehicle just left. Removing this event resolves this ambiguity and makes the behavior of As an added bonus, this change allows for greater flexibility in implementations around when a crossed_geography_boundary event occurs. This is likely to be of use during the beta period as we seek to make stronger recommendations to account for GPS inaccuracy, drift, etc. |
Name seems a little wordy. :) |
William this looks great, thanks for incorporating all the feedback! Will you be available to present on your changes at tomorrow's WG meeting? No need to do an overview of the whole GDE proposal, but just what's been updated, and the decision to merge the leave/enter geographies. Also I noticed a few things in the PR that could be update before tomorrow. If you give me edit access (#2 here) I can make them, otherwise here they are:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good thanks for the changes based on community and city feedback. Will make other minor changes during release candidate preparation (eg like typos with 'telemtry' spelling).
No description provided.