-
Notifications
You must be signed in to change notification settings - Fork 319
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ISSUE#266] Support read state from statemachine with RaftLog-Read mode #266 #267
Merged
tsunghanjacktsai
merged 26 commits into
openmessaging:master
from
TheR1sing3un:support_linearizability_read
Feb 9, 2023
Merged
[ISSUE#266] Support read state from statemachine with RaftLog-Read mode #266 #267
tsunghanjacktsai
merged 26 commits into
openmessaging:master
from
TheR1sing3un:support_linearizability_read
Feb 9, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. fix wrong begin index after applying snapshot
1. fix wrong recover after reset offset
1. pass checkstyle
1. support read from statemachine with raft-log read mode 2. support user define request processor in server and client 2. refactor the appending entry logic 3. refactor some code for better logical relationship
1. add more tests in AppendAndReadTest
[ISSUE 245] fix wrong recover logic after reseting offset
1. fix some problems in snapshot mode
1. fix some problems in snapshot mode
1. use generic to refactor some methods
1. ignore flaky test temporarily
…n_index_after_snapshot [ISSUE#268]Fix wrong ledgerIndex and wrong generated snapshot in snapshot mode
tsunghanjacktsai
approved these changes
Feb 7, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, remember to resolve the conflicts before merging.
1. support read from statemachine with raft-log read mode 2. support user define request processor in server and client 2. refactor the appending entry logic 3. refactor some code for better logical relationship
1. add more tests in AppendAndReadTest
1. use generic to refactor some methods
1. ignore flaky test temporarily
…to support_linearizability_read # Conflicts: # dledger/src/main/java/io/openmessaging/storage/dledger/DLedgerEntryPusher.java
Done~ Plz merge it. Thks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
issue: #266