Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Tabular.from_xml_element for histogram case #3287

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

paulromano
Copy link
Contributor

Description

Due to the change in #2981, I found that Tabular.from_xml_element didn't work for the case when len(x) == len(p) + 1. This PR fixes that.

Checklist

  • I have performed a self-review of my own code
  • I have run clang-format (version 15) on any C++ source files (if applicable)
  • I have followed the style guidelines for Python source files (if applicable)
  • I have made corresponding changes to the documentation (if applicable)
  • I have added tests that prove my fix is effective or that my feature works (if applicable)

@paulromano paulromano requested a review from pshriwise January 31, 2025 14:59
Copy link
Contributor

@pshriwise pshriwise left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @paulromano! I like that the slicing is more explicit now. And thanks for addressing the XML parsing as well.

@pshriwise pshriwise added the Merging Soon PR will be merged in < 24 hrs if no further comments are made. label Jan 31, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Merging Soon PR will be merged in < 24 hrs if no further comments are made.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants