Update xtl and xtensor submodules #2941
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HunterBelanger
changed the title
paulromano
approved these changes
Apr 8, 2024
There was a problem hiding this comment.
Thanks @HunterBelanger! Yes, moving to FetchContent may be a good idea. Let's consider that on a separate issue/PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR updates the xtl and xtensor submodules to be the most recent tagged version of each. This change is motivated by #2919, where I found that the versions that we are currently using appear to have a memory bug in Windows. These more recent versions do not seem to pose any issues for me on linux or Windows.
While this PR currently just updates the submodules, it might also be a good time to discuss possibly moving from submodules to FetchContent. This is a new feature which was added to CMake 3.11 (currently we require 3.10+), which allows you to specify git repos in the CMakeLists file, and then CMake will automatically clone them and set them up on build. I personally find it much easier to work with, and it also avoids the problem of initializing the submodules, and updating versions is just a simple change in the CMakeLists.
Checklist
I have performed a self-review of my own codeI have run clang-format (version 15) on any C++ source files (if applicable)I have followed the style guidelines for Python source files (if applicable)I have made corresponding changes to the documentation (if applicable)I have added tests that prove my fix is effective or that my feature works (if applicable)