Setting surf_source_ attribute for DAGMC surfaces. #2857
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Addresses empty surface source files when this feature is applied to DAGMC surfaces. This is because the
DAGSurface::surf_source_
attribute isn't being set.DAGSurface
's aren't created using the XML node constructor and in turn don't apply the code from theSurface::Surface(pugi::xml_node node)
surface constructor.This simply adds the same check in the
DAGSurface
constructor. In addition to a min-test that particles are generated in the correct location (on the barrel of surafce 1). I then put together a quick and dirty external source site display feature in the plotter to prove to myself it was working using the fuel pin regression test:note:: source sites are projected onto the slice plane regardless of whether or not they are on or approximately on that plane
Model (colored by cell)
Surface 1 (cylinder barrel)
Surface 2 (lower Z surface)
Surface 3 (upper Z surface)
Surfaces 1, 2, and 3
Fixes #2856
Checklist
I have followed the style guidelines for Python source files (if applicable)I have made corresponding changes to the documentation (if applicable)I have added tests that prove my fix is effective or that my feature works (if applicable)