Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modifications to deplete_with_transfer_rates regression test suite #2779

Merged

Conversation

eepeterson
Copy link
Contributor

@eepeterson eepeterson commented Nov 17, 2023

Description

This PR makes the deplete_with_transfer_rates test suite more robust, by setting CoupledOperator.round_number = True. This is done in the deplete_with_transport regression tests to prevent simulations from diverging due to very tiny differences in atom number density. In addition, I tightened the tolerance on the assert_atoms_equal to be the same level of agreement (1e-6) as in the deplete_with_transport tests. Previously the reaction rate assertion had a tighter tolerance than the atom number when it should probably be the inverse. I also changed the test particle and batch numbers to match the other tests as well at the same time. This change also allows PRs #2764 and #2703 to pass without changing the test suite (at least locally).

Checklist

  • I have performed a self-review of my own code
    - [ ] I have run clang-format (version 15) on any C++ source files (if applicable)
  • I have followed the style guidelines for Python source files (if applicable)
    - [ ] I have made corresponding changes to the documentation (if applicable)
    - [ ] I have added tests that prove my fix is effective or that my feature works (if applicable)

Copy link
Contributor

@paulromano paulromano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@eepeterson Thanks for all the (painful) work to figure this one out!

@paulromano paulromano merged commit cad9fdc into openmc-dev:develop Nov 27, 2023
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants