-
Notifications
You must be signed in to change notification settings - Fork 521
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Filter material from #2750
Filter material from #2750
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice addition @bam241! Just a few small questions/comments from me.
Co-authored-by: Patrick Shriwise <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me. Thanks @bam241 for the new filter!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work on this @bam241. Thanks for the addition!
Co-authored-by: Patrick Shriwise <[email protected]> Co-authored-by: Paul Romano <[email protected]>
Description
This aims to implement
MaterialFromFilter
as described in #2719I inspired myself from
CellFromFilter
. I as particule only stores history of cell they travelled through and not materials, I used visited cells to list materials seen previously any the materials.The only cons is that distribcell might contains multiple materials so this detection would be wrong. As particule might have travelled through a distribcell but not seen the requested materials.
in Cell.h line 290-293
If you have any recommandation on how to implement this better, I will be happy to comply. If there is none, I can throw an Error or a Warning, stating that some cell contains multiple material so it is not possible to accurately filter by
MaterialFrom
.Checklist
This work is sponsored by First Light Fusion.