Skip BC check for volume calculations #2743
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paulromano
approved these changes
Oct 20, 2023
There was a problem hiding this comment.
Thanks! Looks good to me, although the change in test_volume.py will have a merge conflict with #2742 so one of them will have to get updated depending on which we merge first.
I set #2742 to merge if CI is successful so I'll wait for that to go in and handle the conflict here. You did submit that one first after all 😃 |
stchaker
pushed a commit
to stchaker/openmc
that referenced
this pull request
Oct 25, 2023
church89
pushed a commit
to openmsr/openmc
that referenced
this pull request
Jul 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is a simple change that, similar to running OpenMC in plotting mode, allows initialization to complete for a geometry without non-transmission boundary conditions when running in volume calculation mode.
Checklist