added python format checker single file at a time #2737
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
new python format checker has failed as intended and printing out how the file should be formatted in the CI https://github.com/openmc-dev/openmc/actions/runs/6574802837 |
|
a single file has been formatted and now the python format checker in CI is now passing https://github.com/openmc-dev/openmc/actions/runs/6574823724 |
shimwell
changed the title
|
I'm going to close this PR I made as:
this can be reopened if anyone wants |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR attempts to
1: add a python format checker to the CI for a single python file
2: show that the format checker fails with reasonable error messages
3: show that the format checker passes after formatting is corrected
I think we could gradually bring all the python files into the same formatting rules but this approach lets us process a single file at a time if that is desired