fixed typo in CF4Integrator docstring #2704
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paulromano
approved these changes
Sep 24, 2023
pshriwise
pushed a commit
to pshriwise/openmc
that referenced
this pull request
Sep 27, 2023
stchaker
pushed a commit
to stchaker/openmc
that referenced
this pull request
Oct 25, 2023
church89
pushed a commit
to openmsr/openmc
that referenced
this pull request
Jul 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The
CF4Integratordocstring has a minus sign where it should be a plus sign in one of the matrix exponential terms. The underlying algorithm implemented in_matrix_funcs.pyis correct so this PR is just reflecting that.Checklist
- [ ] I have run clang-format on any C++ source files (if applicable)- [ ] I have added tests that prove my fix is effective or that my feature works (if applicable)