-
Notifications
You must be signed in to change notification settings - Fork 525
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Limit number of lost particles written to disk. #2688
Conversation
fix the logic such that the dfeult is to write all lost particles
based particle_restart_eigval test
omp threads and/or mpi may create some additional files. protect test against that
The max_lost_write number works per node.
I've now added a regression test - based on the procedure of |
@ebknudsen I've made some updates here on your branch:
Since this was a little bit of a heavy-handed approach of making changes rather than suggestions, let me know if it looks OK to you; happy to iterate further if needed! |
@paulromano Cool. All fine by me. I agree on all your edits and btw. I have absolutely no problem with the direct edits :-). |
Co-authored-by: John Tramm <[email protected]> Co-authored-by: Paul Romano <[email protected]>
Co-authored-by: John Tramm <[email protected]> Co-authored-by: Paul Romano <[email protected]>
Co-authored-by: John Tramm <[email protected]> Co-authored-by: Paul Romano <[email protected]>
Description
This PR adds an option to limit the number of lost particles written to disk. This can be useful in the admittedly rare corner case when debugging leaky geometry models, to avoid being overwhelmed by the sheer number of files.
No regression test has been added - I simply don't know how to reliably generate a simple leaky geometry.
Fixes # (issue)
No present issue
Checklist