Warn users about bad equiprobable angles in S(a,b) #2675
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gridley
requested changes
Sep 1, 2023
Co-authored-by: Gavin Ridley <[email protected]>
paulromano
approved these changes
Sep 1, 2023
|
@gridley If you're satisfied with the changes, can you approve this? Thanks! |
gridley
approved these changes
Sep 6, 2023
|
oops, sorry to hold you all up! |
stchaker
pushed a commit
to stchaker/openmc
that referenced
this pull request
Oct 25, 2023
Co-authored-by: Gavin Ridley <[email protected]> Co-authored-by: Paul Romano <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
A while back, I made some fixes to the TSL processing methodology (see #2290). Back then, I mentioned adding a warning for discrete scattering cosines being outside of [-1,1] (as this could happen with not-that-old versions of NJOY). I forgot to make the second PR for that until now.
I decided to make this a warning and not an error, simply because there are so many ACE files out there with this bug, particularly those distributed with MCNP for ENDF/B-VII.1. Users might want to run with that data, to make comparisons against different libraries or codes.
Checklist
I have run clang-format on any C++ source files (if applicable)I have made corresponding changes to the documentation (if applicable)I have added tests that prove my fix is effective or that my feature works (if applicable)