-
Notifications
You must be signed in to change notification settings - Fork 525
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds MPACT library group structures and documentation to mgxs collection #2614
Adds MPACT library group structures and documentation to mgxs collection #2614
Conversation
144d25c
to
2e1042e
Compare
2e1042e
to
29bcd8b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this contribution @bscollin! I looked at the reference provided in the comment but I only see the definition for the 51 group structure there. Where can one find the definition for the other structures?
@paulromano, I pulled the data straight from the cross-section library files distributed with VERA. I talked with Aaron Graham @aarograh, the VERA project lead at ORNL and he was okay with releasing these. I did find a reference to the 69g Magnox library: https://www.epj-conferences.org/articles/epjconf/pdf/2021/01/epjconf_physor2020_10016.pdf |
Thanks @bscollin. Could you put those references in the docstring below |
007a16e
to
dc4848c
Compare
dc4848c
to
2b00d58
Compare
@paulromano All requests addressed. Added references to 69g library, renamed 252g library to SCALE-252 and added reference. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @bscollin!
Description
Group structures from the MPACT reactor physics code are added to the
mgxs.GROUP_STRUCTURES
python dictionary. These include a 51g structure used primarily for PWRs, a 60g structure developed for BWRs, a 69g structure developed for Magnox reactors, and a 252g structure that should be good for most thermal systems.Fixes # N/A
Checklist