Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds MPACT library group structures and documentation to mgxs collection #2614

Merged
merged 2 commits into from
Jul 25, 2023

Conversation

bscollin
Copy link
Contributor

@bscollin bscollin commented Jul 19, 2023

Description

Group structures from the MPACT reactor physics code are added to the mgxs.GROUP_STRUCTURES python dictionary. These include a 51g structure used primarily for PWRs, a 60g structure developed for BWRs, a 69g structure developed for Magnox reactors, and a 252g structure that should be good for most thermal systems.

Fixes # N/A

Checklist

  • I have performed a self-review of my own code
  • I have followed the style guidelines for Python source files (if applicable)
  • I have made corresponding changes to the documentation (if applicable)

@bscollin bscollin force-pushed the mpact_group_structure branch from 144d25c to 2e1042e Compare July 19, 2023 15:33
@bscollin bscollin force-pushed the mpact_group_structure branch from 2e1042e to 29bcd8b Compare July 19, 2023 15:35
Copy link
Contributor

@paulromano paulromano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this contribution @bscollin! I looked at the reference provided in the comment but I only see the definition for the 51 group structure there. Where can one find the definition for the other structures?

@bscollin
Copy link
Contributor Author

@paulromano, I pulled the data straight from the cross-section library files distributed with VERA. I talked with Aaron Graham @aarograh, the VERA project lead at ORNL and he was okay with releasing these. I did find a reference to the 69g Magnox library: https://www.epj-conferences.org/articles/epjconf/pdf/2021/01/epjconf_physor2020_10016.pdf
and the 252g is the same as scale:
https://serpent.vtt.fi/mediawiki/index.php/SCALE_252-group_structure
It doesn't look like they have published the BWR library structure anywhere. I can back that one out if you would like me to. I can also add the extra references, I just didn't want to flood the references with MPACT ones.

@paulromano
Copy link
Contributor

Thanks @bscollin. Could you put those references in the docstring below GROUP_STRUCTURES? Also, should we refer to the 252 group structure as "SCALE-252" instead of "MPACT-252"?

@bscollin bscollin force-pushed the mpact_group_structure branch 2 times, most recently from 007a16e to dc4848c Compare July 25, 2023 13:25
@bscollin bscollin force-pushed the mpact_group_structure branch from dc4848c to 2b00d58 Compare July 25, 2023 13:33
@bscollin
Copy link
Contributor Author

@paulromano All requests addressed. Added references to 69g library, renamed 252g library to SCALE-252 and added reference.

Copy link
Contributor

@paulromano paulromano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @bscollin!

@paulromano paulromano merged commit cd13d34 into openmc-dev:develop Jul 25, 2023
stchaker pushed a commit to stchaker/openmc that referenced this pull request Oct 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants