Fix R < r torus intersection bug #2589
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the case when R < r the inner "imaginary" surfaces created an additional source of scattering close to the center of the torus. This error occurred due to the lack of a check in the solution of the torus equation. If we describe the equation in more detail, we obtain the following: . We see that the left part should obviously be less than or equal to zero. This check was missing in the code of surface.cpp file and was added in lines 972-978.
paulromano
requested changes
Jul 14, 2023
Thanks! It is a better way to perform this check Co-authored-by: Paul Romano <[email protected]>
paulromano
reviewed
Jul 14, 2023
paulromano
approved these changes
Jul 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In the case when R < r the inner "imaginary" surfaces created an additional source of scattering close to the center of the torus. This error occurred due to the lack of a check in the solution of the torus equation. If we describe the equation in more detail, we obtain the following:
We see that the left part should obviously be greater than or equal to zero.
As a result of OpenMC with these geometry parameters (torus_test_xml.tar.gz), there is an anomaly in the form of surfaces inside, which in fact should not be:
This check was missing in the code of surface.cpp file and was added in lines 974-978. After fixing this error, the torus image looks correct:
This is probably not a common problem, but I encountered it when calculating heat in one of the projects, where there was an anomalous surface where it should not be.
Fixes # (issue)
Checklist