Option units for geometry plot #2575
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
would you also expect when plotting meshes on said geometry the flux to renomalise to m^2 or not?
…On Jun 22 2023, at 4:35 pm, Jonathan Shimwell ***@***.***> wrote:
Description
It would be handy for people with large models to be able to plot geometry with different units to the default cm. For example I have a few models where meters would be idea. Is there any chance we can allow axis units on the universe.plot
Fixes # (issue)
No issue sorry
Checklist
I have performed a self-review of my own code
I have run clang-format (https://docs.openmc.org/en/latest/devguide/styleguide.html#automatic-formatting) on any C++ source files (if applicable)
I have followed the style guidelines (https://docs.openmc.org/en/latest/devguide/styleguide.html#python) for Python source files (if applicable)
I have made corresponding changes to the documentation (if applicable)
I have added tests that prove my fix is effective or that my feature works (if applicable)
You can view, comment on, or merge this pull request online at:
#2575
Commit Summary
79a5302 (79a5302) geometry plots in mm, cm, m, km
7f1678d (7f1678d) added doc string for axis_units
File Changes
(1 file (https://github.com/openmc-dev/openmc/pull/2575/files))
M openmc/universe.py (https://github.com/openmc-dev/openmc/pull/2575/files#diff-a36af801338f90369cff49559fb0943fb1135e0a7c9e9c935b7de7514138f5bd) (22)
Patch Links:
https://github.com/openmc-dev/openmc/pull/2575.patch
https://github.com/openmc-dev/openmc/pull/2575.diff
—
Reply to this email directly, view it on GitHub (#2575), or unsubscribe (https://github.com/notifications/unsubscribe-auth/AASTUSV3MS2ASMTEY5OQVYTXMRQ5TANCNFSM6AAAAAAZQMPGIQ).
You are receiving this because you are subscribed to this thread.
|
|
I had not really thought about mesh plots. This proposed change is to the geometry plotting which is currently disconnected to mesh plotting. |
|
tests appear to be failing on np.product which has changed to np.prod. There is a PR in for fixing that already so I think that is unrelated to this PR |
paulromano
requested changes
Jun 22, 2023
There was a problem hiding this comment.
Thanks for this improvement @shimwell! Pushing another commit here should resolve the test failures
Co-authored-by: Paul Romano <[email protected]>
paulromano
approved these changes
Jun 23, 2023
|
Thanks Paul, tests are passing again now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
It would be handy for people with large models to be able to plot geometry with different units. The default is still cm so this won't break anything for existing scripts. I have a few models where meters would be ideal so I would just add
axis_units='m'to the arguments. Is there any chance we can allow axis units on theuniverse.plot?Fixes # (issue)
No issue sorry
Checklist