Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use multiply_density in depletion reaction rate helper classes #2559

Merged
merged 4 commits into from
Jun 15, 2023

Conversation

paulromano
Copy link
Contributor

This PR is a follow on to #2539 and updates the depletion system in OpenMC to utilize the new multiply_density option. Since depletion only requires microscopic reaction rates, there's no need to have the tally system multiply by atom density only to divide it out later. With changes here, we now avoid that.

These changes will allow us to get rid of dilute_initial altogether. In fact, I already have that working on a branch but will save it for a separate PR because it does result in test changes. The changes in this PR require no updates to test results.

@paulromano paulromano requested a review from drewejohnson as a code owner June 9, 2023 13:58
Copy link
Contributor

@drewejohnson drewejohnson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just want to make sure I follow the logic

  • new tally feature used in depletion does not scale reaction rate tallies by the number density of the target nuclide.
  • Depletion backend doesn't really need reaction rates with units atoms/barn-cm, but we do need them to be absolute
  • So we need to re-incorporate the volume of the tallied domain (materials) into the tallies

That all checks out to me. I'm happy to merge this through as is, comments are non-blocking

openmc/deplete/helpers.py Outdated Show resolved Hide resolved
openmc/deplete/independent_operator.py Show resolved Hide resolved
@paulromano
Copy link
Contributor Author

@drewejohnson Any further comments on this or do you think it's good to merge? btw, thanks for chiming in! Wasn't sure if you were paying attention to the day-to-day OpenMC happenings anymore 😄

@drewejohnson
Copy link
Contributor

Thanks @paulromano! I see things on occasion and try to help where I can! Not so much day to day, maybe month to month 😅

@drewejohnson drewejohnson merged commit 787b3e0 into openmc-dev:develop Jun 15, 2023
@paulromano paulromano deleted the depletion-microxs branch June 15, 2023 11:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants