Auto origin and width for plots #2492
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paulromano
requested changes
Apr 28, 2023
shimwell
commented
Apr 28, 2023
paulromano
requested changes
May 2, 2023
Co-authored-by: Paul Romano <[email protected]>
shimwell
added
the
Merging Soon
pshriwise
pushed a commit
to pshriwise/openmc
that referenced
this pull request
May 12, 2023
Co-authored-by: Paul Romano <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR attempts to automate two arguments in the
universe.plotmethod.Currently the
origindefaults to(0,0,0)which is often the center of the geometry. However this PR attempts to find the center of the geometry using the new bounding box classCurrently the
widthis set to(1,1)which is occasionally the size of the geometry. However this PR attempts to find the axis width for the user using the new bounding box class.I think these new defaults will help users produce plots quicker and with less knowledge of the geometry being plotted.
However they might slow down the plotting for very large geometry where the bounding box takes time to calculate. In that case the user might want to specify the width and origin manually.