Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Install vectfit in CI without build isolation #2481

Merged
merged 2 commits into from
Apr 17, 2023
Merged

Install vectfit in CI without build isolation #2481

merged 2 commits into from
Apr 17, 2023

Conversation

paulromano
Copy link
Contributor

It looks like recent CI runs are failing due to a new release of pip that removes a setup.py install fallback. This PR attempts to fix this by turning off build isolation when installing vectfit.

@shimwell shimwell mentioned this pull request Apr 17, 2023
Merged
jtramm
jtramm approved these changes Apr 17, 2023
View reviewed changes
Copy link
Contributor

@jtramm jtramm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI tests ran successfully again, so LGTM!

I am going to skip the usual 24-hour waiting period given that the scope is so limited and the issue is with the CI testing itself.

@jtramm jtramm merged commit 2b23b73 into openmc-dev:develop Apr 17, 2023
@paulromano paulromano mentioned this pull request Apr 17, 2023
Merged
@paulromano paulromano deleted the vectfit-ci-fix branch April 17, 2023 18:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jtramm jtramm jtramm approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@paulromano @jtramm