Added type hints for WeightWindows class #2462
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paulromano
requested changes
Apr 7, 2023
There was a problem hiding this comment.
Thanks for contribution @christinacai123! (and thanks to @shimwell for helping guide some first-time contributors). For the suggested changes below, note that you can batch them together as one commit directly in the web interface.
|
Super to see you made it from discourse to GitHub so quickly. Nice one Hit all the "add suggestion to batch" buttons on this page as the next step |
Co-authored-by: Paul Romano <[email protected]>
Co-authored-by: Paul Romano <[email protected]>
christinacai123
commented
Apr 10, 2023
paulromano
changed the title
paulromano
approved these changes
Apr 10, 2023
paulromano
added
the
Merging Soon
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.