allowing materials.xml to be specified #2364
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks @shimwell! This is indeed helpful for those workflows. |
eepeterson
approved these changes
Jan 27, 2023
paulromano
requested changes
Jan 28, 2023
shimwell
commented
Jan 28, 2023
paulromano
approved these changes
Jan 31, 2023
|
I have merged in the latest develop branch (which fixes the CI) and am now rerunning the tests as I think that a pass is required to merge this PR |
|
Super tests are passing, I think this is ready to merge |
|
Thanks @shimwell. For future reference, you don't actually need to merge in develop to your branch. When CI runs, it is actually testing a merge commit, so just retriggering CI once the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
Results.export_to_materialsmethod inopenmc.depleteis super useful.This PR is an attempt to make it a tiny bit more flexible by allowing the path to the materials.xml to be specified.
This is useful when running multiple depletion steps and wanting to get the materials for a seperate folder or elsewhere.
It is useful to have the different stages stored in separate file locations so that the materials at each time step can be investigated.
Would you be able to review @eepeterson as this is similar to changes you had in your R2SModel branch but I've tried to use the path argument with PathLike the same way it is used elsewhere in openmc (e.g. here)