added energy cut for decay photons #2316
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This topic has come up on discourse before on discourse and also on @eepeterson R2Smodel branch.
Perhaps it is worth adding some low energy cut to
material.decay_photon_energy
to allow users to conveniently remove low energy photons from the simulation. These low energy photons cause issues during transport so we could even have a default set to remove them automatically but perhaps that is a step to far.I'm sure there are more efficient ways of doing this, perhaps in the C++ layer we could automatically not transport these photons. However this approach allow users to be aware that they are getting removed from the source.
So I've thrown together this PR for your consideration it is based on @paulromano comment on discourse and @eepeterson R2sModel branch. If people think this is worth considering then I would be keen to add some tests