Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added energy cut for decay photons #2316

Conversation

shimwell
Copy link
Member

@shimwell shimwell commented Dec 2, 2022

This topic has come up on discourse before on discourse and also on @eepeterson R2Smodel branch.

Perhaps it is worth adding some low energy cut to material.decay_photon_energy to allow users to conveniently remove low energy photons from the simulation. These low energy photons cause issues during transport so we could even have a default set to remove them automatically but perhaps that is a step to far.

I'm sure there are more efficient ways of doing this, perhaps in the C++ layer we could automatically not transport these photons. However this approach allow users to be aware that they are getting removed from the source.

So I've thrown together this PR for your consideration it is based on @paulromano comment on discourse and @eepeterson R2sModel branch. If people think this is worth considering then I would be keen to add some tests

@paulromano
Copy link
Contributor

@shimwell Thanks for proposing this PR. I think I'd prefer a fix at the C++ level that doesn't require us to cut out these photons at an early stage. Ideally, these low energy photons would just immediately die and deposit their energy. This has bothered me too so I'll see if I can put a fix together and submit a PR.

@shimwell
Copy link
Member Author

shimwell commented Dec 5, 2022

Thanks for looking into this Paul, much appreciated 👍.

Closing this PR in favour of doing it probably in the c++ layer in PR ##2319

@shimwell shimwell closed this Dec 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants