Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix zero-valued runtime attribute in depletion statepoints. #2302

Merged
merged 3 commits into from
Nov 23, 2022
Merged

Fix zero-valued runtime attribute in depletion statepoints. #2302

merged 3 commits into from
Nov 23, 2022

Conversation

yardasol
Copy link
Contributor

This PR addressed the problem described in issue #2289.

Specifically, this PR:

  • Moves openmc.lib.reset_timers() from CoupledOperator.__call__() to CoupledOperator.write_bos_data()
  • Adds some lines to the depletion_with_transport regression test to check the runtime attributes.

Closes #2289.

@yardasol yardasol requested a review from paulromano November 18, 2022 16:56
@yardasol yardasol force-pushed the depletion-statepoints-fix branch from 6679b14 to d45c37b Compare November 18, 2022 21:49
@yardasol yardasol added the I/O File Input/Output label Nov 18, 2022
paulromano
paulromano requested changes Nov 19, 2022
View reviewed changes
Copy link
Contributor

@paulromano paulromano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix @yardasol! One suggestion on the test:

tests/regression_tests/deplete_with_transport/test.py Outdated Show resolved Hide resolved
@yardasol yardasol force-pushed the depletion-statepoints-fix branch from a8e5cb2 to fea5ba8 Compare November 21, 2022 21:35
paulromano
paulromano approved these changes Nov 21, 2022
View reviewed changes
Copy link
Contributor

@paulromano paulromano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the updates; LGTM!

@yardasol yardasol requested a review from paulromano November 21, 2022 21:41
@yardasol
Copy link
Contributor Author

@paulromano I added your suggested change. I didn't know defaultdict was a thing!

@yardasol yardasol force-pushed the depletion-statepoints-fix branch 2 times, most recently from c63d287 to 8163d7a Compare November 22, 2022 13:27
@yardasol @paulromano
use defaultdict
8163d7a 
Co-authored-by: Paul Romano <[email protected]>
@yardasol yardasol requested a review from paulromano November 23, 2022 07:36
@paulromano paulromano merged commit 33ead74 into openmc-dev:develop Nov 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@paulromano paulromano paulromano approved these changes

@drewejohnson drewejohnson Awaiting requested review from drewejohnson

Assignees
No one assigned
Labels
Bugs Depletion I/O File Input/Output
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

StatePoint.runtime incorrectly written from depletion simulation.
2 participants
@yardasol @paulromano