Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix wwinp reader #2242

Merged
merged 6 commits into from
Oct 3, 2022
Merged

fix wwinp reader #2242

merged 6 commits into from
Oct 3, 2022

Conversation

eepeterson
Copy link
Contributor

I realized our wwinp reader isn't parsing energy dependent weight windows correctly. The energy and time bin indices vary slower in the MCNP file format than the spatial mesh indices, not faster as we implemented.

@eepeterson eepeterson requested a review from pshriwise October 2, 2022 15:09
Copy link
Contributor

@pshriwise pshriwise left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this fix @eepeterson!

tests/unit_tests/weightwindows/test_wwinp_reader.py Outdated Show resolved Hide resolved
Copy link
Contributor

@pshriwise pshriwise left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @eepeterson!

@pshriwise pshriwise merged commit 6c698e3 into openmc-dev:develop Oct 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants