Fix TimeFilter for very small time intervals with tracklength estimator #2168
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pshriwise
approved these changes
Aug 15, 2022
There was a problem hiding this comment.
Thanks @paulromano! Changes look good to me. Tried the test out w/o the fix and got a zero tally with the filter applied as described. ( test works with the fix of course 😄 )
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #2156. The issue is as follows: if you have a source with a large time specified, e.g., 1.0e8 seconds, the time interval over a single track might be so small that the starting and ending time for that track are effectively the same. This is just a result of floating-point arithmetic because it's possible to have$t + Δt = t$ in if $Δt$ is small relative to $t$ . Right now, such tracks will not get marked as match for a time filter even if the starting time is within a specified time bin. This is now fixed in
TimeFilter::get_all_binsand for good measure, I've added a test that checks this particular condition.Thanks to @tibetscarlett for identifying the issue and giving a proposed solution!