Fix a corner case in Region.from_expression #2081
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pshriwise
approved these changes
Jun 9, 2022
|
@pshriwise I just added a one-line change in this PR to address #2082. Hope you don't mind! |
Works for me! I'll merge later today if there are no other comments. |
pshriwise
approved these changes
Jun 10, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If you pass the expression
1(2|-3)toRegion.from_expressionright now, it doesn't recognize that there's an implicit intersection operator between the1and the(. This PR fixes this behavior to correctly insert the intersection operator between them and is accompanied by a (previously failing) test case.Once again, this bug was found as a result of working with the ITER E-lite model.