Allow photon heating to be tallied by nuclide #2076
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pshriwise
approved these changes
Jun 7, 2022
There was a problem hiding this comment.
Pretty straightforward change. Nice test to go with it too. Thanks @paulromano!
|
@makeclean I'll give this another day or so before merging in case you'd like to have a look. |
|
Sorry @paulromano, just saw the closed message. Thanks for the fix, I thought it was going to be significantly more complicated than the change you made, so I didn't even attempt myself :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@makeclean pointed out that if you tally heating for photons and ask for it by nuclide, every nuclide currently gives the same value (corresponding to the total). Since photon heating is done in an analog fashion, this PR changes the photon heating score to check which nuclide was responsible for a collision and only score for that nuclide. I've added a unit test that checks for the correct behavior: sum of heating from each nuclide should equal total heating.