-
Notifications
You must be signed in to change notification settings - Fork 525
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Cmake to allow third-party libraries #2006
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @kkiesling and congrats on your first PR here! 🎉 Just a few comments regarding how we handle xtl
I think I have at least one solution to one of the build errors coming from For the other build error with |
…onsistent with vendored versions
One last change and hopefully this makes it work- I updated the xtl and xtensor versions on the CI build script for vectfit to be the versions that are vendored. This new find_package change was finding the versions installed with vectfit, but they were too old and didn't have some of the functions currently used by openmc. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Thanks for working through the strange build issues 😄 Will merge tomorrow morning if there's no more feedback
This addresses #1779. CMake will now search for existing installations of xtensor, xtl, and gsl-lite and use those instead. If not found, it'll use the vendored submodules.