Ensure secondary particles below energy cutoff are not created #1924
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A user observed that in a photon transport problem, photons were being created (and contributing to flux) below the specified energy cutoff. The fix for this is simple -- I've added a check in
Particle::create_secondary
that prevents the secondary particle from being created if it's below the energy cutoff. Along with this, I've added a unit test that confirms the correct behavior, namely that no flux appears below the energy cutoff but that the total heating is not affected (the test uses an infinite medium problem, so the entirely of the source energy should be deposited regardless of the presence of an energy cutoff).@amandalund since you're the expert with particle cutoffs/ secondary creation, would you mind reviewing?