Prevent divide-by-zero in bins_crossed methods for meshes #1816
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paulromano
force-pushed
the
mesh-nan-fix
branch
from
0be61bf to
25334a6
Compare
|
FYI, there's some weird issue with GHA ubuntu VMs right now that is causing our tests to fail when MPI is enabled (tests for #1817 are failing for same reason). I've put in a workaround in this PR based on some comments from the linked issue. |
|
Looks good to me! |
aprilnovak
approved these changes
Apr 20, 2021
pshriwise
pushed a commit
to pshriwise/openmc
that referenced
this pull request
Apr 24, 2021
Prevent divide-by-zero in bins_crossed methods for meshes
pshriwise
pushed a commit
to pshriwise/openmc
that referenced
this pull request
Apr 24, 2021
Prevent divide-by-zero in bins_crossed methods for meshes
pshriwise
pushed a commit
to pshriwise/openmc
that referenced
this pull request
Apr 24, 2021
Prevent divide-by-zero in bins_crossed methods for meshes
pshriwise
pushed a commit
to pshriwise/openmc
that referenced
this pull request
Apr 26, 2021
Prevent divide-by-zero in bins_crossed methods for meshes
paulromano
pushed a commit
that referenced
this pull request
Apr 26, 2021
Prevent divide-by-zero in bins_crossed methods for meshes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A user recently reported seeing some NaNs in photon flux mesh tallies. I traced this down to some divide-by-zeros in
StructuredMesh::bins_crossed. This PR simply checks whether the total distance in a track is zero (as can happen when secondary electrons/positrons are created and immediately killed) and returns to prevent the divide-by-zero issue.Also, I noticed that the
rectangular_prismfunction doesn't work cleanly with periodic boundary conditions after our boundary condition refactor (#1701). Also included a fix for that.