cover a previously missed quadric edge case #1812
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paulromano
approved these changes
Apr 7, 2021
There was a problem hiding this comment.
Makes sense to me. Thanks @gridley! I'll leave it open for a little bit in case others have thoughts.
pshriwise
pushed a commit
to pshriwise/openmc
that referenced
this pull request
Apr 24, 2021
cover a previously missed quadric edge case
pshriwise
pushed a commit
to pshriwise/openmc
that referenced
this pull request
Apr 24, 2021
cover a previously missed quadric edge case
pshriwise
pushed a commit
to pshriwise/openmc
that referenced
this pull request
Apr 24, 2021
cover a previously missed quadric edge case
pshriwise
pushed a commit
to pshriwise/openmc
that referenced
this pull request
Apr 26, 2021
cover a previously missed quadric edge case
paulromano
added a commit
that referenced
this pull request
Apr 26, 2021
cover a previously missed quadric edge case
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1811
There is a measure zero set of quadric/particle orientations that lead to division by zero in the quadric intersection routine. One likely example is if a user inputs a general plane as a quadric, which will cause failure of this routine every time at the moment and segfault OpenMC, as shown in #1811. the code comment explains a little more. I think there are other edge cases this covers, but haven't put time into figuring what exactly they are.