Fix for data crossover in VTK filess when using multiple tallies w/ unstructured mesh. #1645
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paulromano
requested changes
Aug 26, 2020
There was a problem hiding this comment.
One little change requested -- otherwise looks fine to me. Thanks @pshriwise!
Including suggested change from @paulromano Co-authored-by: Paul Romano <[email protected]>
paulromano
approved these changes
Aug 26, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A user noted that unstructured mesh tally data from one tally was being written in the VTK file of another tally.
This PR adds the
UnstructuredMesh::remove_scoremethod and applies it inwrite_unstructured_mesh_resultsto clear out data between tallies when writing VTK files.