Fix bug when S(a,b) tables appear in depletable material #1605
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Just added one more bugfix for #1600. |
drewejohnson
approved these changes
Jul 15, 2020
There was a problem hiding this comment.
Nice and simple PR @paulromano!
Looks like Travis is being a bit funky though. The build has passed, but there is a second CI check that has stalled? Or isn't reporting back?
|
Yeah, something wacky going on with Travis there. I've temporarily disabled the status check rules so you should be able to merge now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A user noted that when they used the
c_H_in_ZrHandc_Zr_in_ZrHS(a,b) tables in a material that was depletable, they ran into an error on the second iteration where the code complains that a nuclide is present in two tables. This is due to a bug in how thermal scattering tables are assigned (there was an implicit assumption this was only done once, but in depletion, the assignment happens each time a material is updated).Unrelated to the above: I also put in a small fix here to ensure
IncidentNeutron.from_endfworks with all TENDL-2019 files. Some of the fissionable nuclides (e.g., Ra234) list only one precursor group in MF=1,MT=455, but then list 6 separate energy spectra in MF=5,MT=455. The intention is to use the probability of selecting the energy spectra as a way of turning 1 group into 6 (this is how NJOY treats it when producing ACE files).