DAGMC Updates/Fixes #1604
Merged
DAGMC Updates/Fixes #1604
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paulromano
approved these changes
Jul 8, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains a fix for implicit complement material assignment in DAGMC and allows all material assignments to rely on a class dedicated to DAGMC metadata management by relaxing the restriction that a density be supplied along with a material assignment in the DAGMC
.h5mfile. The relevant changes to DAGMC to allow that can be found here.Similar updates to how boundary conditions are found have been made as well (corresponding changes in DAGMC to support the variety of boundary conditions in OpenMC can be found here).
These changes make the code for DAGMC setup cleaner, avoiding a lot of duplicate queries for property information and removal of error code checks for calls directly into the DAGMC interface.
The final update here is a change from the use of blas/lapack to eigen3 when building DAGMC. Eigen3 is a C++ template library, making a theoretical build of DAGMC on Windows viable. It is rapidly becoming the default build for DAGMC and it's best that we go ahead and reflect that change in our CI as well.