Fix bug for distributed temperatures without distributed materials #1178
Conversation
|
@smharper Seems like this has been a recurring problem -- can you add a test for this case? |
|
I just looked into adding a test. Unfortunately, I don't think we'll be able to catch this bug with any tests until we start using pointwise cross sections with multiple temperatures for our test suite. For example, the multipole regression test should trigger this condition (distribtemps without distribmats), but it doesn't matter because |
| } else { | ||
| for (double sqrtkT : cell->sqrtkT_) | ||
| cell_temps.push_back(sqrtkT*sqrtkT / K_BOLTZMANN); | ||
| } |
There was a problem hiding this comment.
Seems like determining cell_temps ought to be done as a separate loop above the loop over cell->material_.size() (line 165). Effectively in each case, we're iteratating over cell->sqrtkT_.
There was a problem hiding this comment.
So populate the cell_temps array before the cell->material_.size() loop? I think that way we could end up with loading more temperature data than needed. If every cell instance has a different material and different temperature, then each material only needs to load one temperature.
There was a problem hiding this comment.
Ah yes, you're right. I felt like I might be missing something!
When we call
get_temperaturesto find out what temps are assigned to each nuclide, there's a bug that occurs related to distributed temperatures. We correctly account for the case where the cell has one temperature and many materials, or N temperatures and N materials, but we missed the case where it has many temperatures and only one material.