Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add motorway_contruction layer #44

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Conversation

zbycz
Copy link

@zbycz zbycz commented Aug 24, 2021

For preview URL see zbycz/osmapp#61
Its live – just check eg. https://osmapp.org/#16.30/49.6688/18.3240

I think this could be designed more nicely, but i guess it works as is.

@frodrigo
Copy link
Contributor

There is already a lot of transportation layer. Adding more not seam to me as good move.

Maybe done using a condition inside existing one.

@zbycz
Copy link
Author

zbycz commented Aug 30, 2021

Hi @frodrigo, can you please explain what condition do you mean? As this uses completely different source_layer we have to add new display layer I guess. //cc @TomPohys ?

style.json Outdated
{
"id": "highway-motorway-construction",
"type": "line",
"source": "maptiler_planet",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The only source here is openmaptiles.

@frodrigo
Copy link
Contributor

Hi @frodrigo, can you please explain what condition do you mean? As this uses completely different source_layer we have to add new display layer I guess. //cc @TomPohys ?

You source layer here is just transportation.

I talk about https://maplibre.org/maplibre-gl-js-docs/style-spec/expressions/

@petraduriancikova
Copy link

Hi Pavel, as @frodrigo pointed out, there is an incorrect data source, it should be indeed openmaptiles. I think it's a good idea to add construction roads, but instead of just one class motorway_construction, IMHO it would be beneficial to add also trunk_construction, primary, secondary, tertiary etc. Line-color and line-width styling of these can be done based on match expressions. Adding one additional layer like this to the transportation is IMHO ok. If it's added to the existing layers, the styling will be quite complex. I think the construction roads should also use a dashed line instead of a solid one.
cc @TomPohys

@zbycz
Copy link
Author

zbycz commented Jun 21, 2024

@petraduriancikova thanks for the clarification. I changed the source layer. Feel free to merge this, we can iterate on different road classes later.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants