Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Show newline symbols in llb.Run custom name #241

Merged
merged 1 commit into from
May 13, 2021
Merged

Show newline symbols in llb.Run custom name #241

merged 1 commit into from
May 13, 2021

Conversation

hinshun
Copy link
Contributor

@hinshun hinshun commented May 7, 2021

  • Currently newlines from multi-line runs like heredoc are eliminated from the custom name returned back in the progress UI.
  • Multi-line progress line items don't render well, but having the literal symbol \n looks better and doesn't remove information.

@hinshun hinshun requested a review from coryb May 8, 2021 05:10
@hinshun hinshun merged commit 53c7d05 into openllb:master May 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aaronlehmann aaronlehmann aaronlehmann approved these changes

@coryb coryb coryb approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hinshun @coryb @aaronlehmann