Added new element type: ExternalSignature

[jtrein]

From @fforbeck:

It adds a new element type called ExternalSignature, which is an Identity type with a service name used to indicate which service must sign the contract.

🚨 Dependencies:

1. External Signature integration in core openlaw-core#165
2. External signature integration openlaw-client#86

[jtrein]

I've approved this in the old PR: #68

Reposting feedback:

Looks good! I added only a few small changes to align with another branch I am working in. Just getting ahead.

Question

Is it possible to obtain the serviceName separate from the savedValue (e.g. Openlaw.getExternalServiceName(variable))? It may be nice to show the signing serviceName in the UI, especially if the user opts for a generic placeholder, like "Email". The reason I ask is that it suddenly appears when there is a savedValue, but is not present if not.

[jtrein]

@jdville03 I can't approve this b/c I opened a new PR. Could you, if you have time, review? Or re-approve the changes?

Though, we don't want to merge this, until the above dependencies have been satisfied.

[jdville03]

Is it possible to obtain the serviceName separate from the savedValue (e.g. Openlaw.getExternalServiceName(variable))? It may be nice to show the signing serviceName in the UI, especially if the user opts for a generic placeholder, like "Email". The reason I ask is that it suddenly appears when there is a savedValue, but is not present if not.

Yeah I agree that could be convenient to have.

[jdville03]

This looks good to me too. We'll just need to update package.json when this is ready to merge.

[fforbeck]

@jtrein
the serviceName is a required field for that variable type, the user has to provide a valid name. Right now we don't have this validation in place, but the idea is to check if the user added a name that matches the services that are registered into Integrators API. If the service name does not match, we would raise an error in the template editor, so we make sure it will always have a valid value to display in the UI.

[jtrein]

Thank you, @fforbeck. Makes sense. I’ll create an issue for Elements repo, so I don’t forget about that label.