Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide more detail in exception #473

Merged
merged 1 commit into from
Jun 14, 2024

Conversation

tamird
Copy link
Contributor

@tamird tamird commented Jun 12, 2024

Description (e.g. "Related to ...", etc.)

See microsoft/vscode-pylint#510 where this
exception arises.

Code review checklist (for code reviewer to complete)

  • Pull request represents a single change (i.e. not fixing disparate/unrelated things in a single PR)
  • Title summarizes what is changing
  • Commit messages are meaningful (see this for details)
  • Tests have been included and/or updated, as appropriate
  • Docstrings have been included and/or updated, as appropriate
  • Standalone docs have been updated accordingly

Automated linters

You can run the lints that are run on CI locally with:

poetry install --all-extras --with dev
poetry run poe lint

@tamird tamird force-pushed the improve-error-message branch from 1497d33 to 5e841fa Compare June 12, 2024 19:35
@tamird
Copy link
Contributor Author

tamird commented Jun 12, 2024

Updated the commit message to appease commitlint.

@tamird
Copy link
Contributor Author

tamird commented Jun 14, 2024

Checks are passing. Is this ready to review/merge?

@tombh
Copy link
Collaborator

tombh commented Jun 14, 2024

I apologise, I often forget to come back after clicking "Approve run".

Thanks for the PR ♥️

@tombh tombh merged commit ea5c3f5 into openlawlibrary:main Jun 14, 2024
16 checks passed
@tamird tamird deleted the improve-error-message branch June 14, 2024 17:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants