Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add Document and Workspace symbol example server #470

Merged
merged 1 commit into from
Jun 6, 2024

Conversation

alcarney
Copy link
Collaborator

@alcarney alcarney commented Jun 6, 2024

Description (e.g. "Related to ...", etc.)

image

Another example server, this time implementing the textDocument/documentSymbol and workspace/symbol requests

Code review checklist (for code reviewer to complete)

  • Pull request represents a single change (i.e. not fixing disparate/unrelated things in a single PR)
  • Title summarizes what is changing
  • Commit messages are meaningful (see this for details)
  • Tests have been included and/or updated, as appropriate
  • Docstrings have been included and/or updated, as appropriate
  • Standalone docs have been updated accordingly

Automated linters

You can run the lints that are run on CI locally with:

poetry install --all-extras --with dev
poetry run poe lint

tombh
tombh previously approved these changes Jun 6, 2024
Copy link
Collaborator

@tombh tombh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The "pretend programming language", even writing your own programming languages now 😏 Nice haha

@alcarney
Copy link
Collaborator Author

alcarney commented Jun 6, 2024

even writing your own programming languages now

Mainly to try and make the language "parsing" code as simple as possible so we can focus on the LSP stuff :)

Could you approve it again? You were a bit quick on the draw I'm afraid 😅

@alcarney alcarney requested a review from tombh June 6, 2024 20:25
@alcarney alcarney merged commit 2dc5a3d into openlawlibrary:main Jun 6, 2024
16 checks passed
@alcarney
Copy link
Collaborator Author

alcarney commented Jun 6, 2024

Thanks!

@alcarney alcarney deleted the symbols-example branch June 6, 2024 20:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants